MINOR: [Go][CI][Benchmarking] Fix GitHub info in Go benchmarks #14952
Conversation
| SCRIPTS_PATH = ARROW_ROOT / "ci" / "scripts" | ||
| RUN_REASON = "commit" if os.environ.get("CONBENCH_REF") == "master" else "branch" | ||
|
|
||
| if os.environ.get("CONBENCH_REF") == "master": |
There was a problem hiding this comment.
is CONBENCH_REF set in the workflow?
There was a problem hiding this comment.
Yes, here:
arrow/.github/workflows/go.yml
Line 91 in 794aefd
|
build is failing because of #14949 |
|
@austin3dickey @zeroshade Benchmark CI is still failing: https://github.com/apache/arrow/actions/runs/3699179581/jobs/6266261796#step:7:1212 Could you fix it (or remove benchmark job in master) before improving Go benchmark? Duplicated: #14921 (comment) |
As mentioned by @ kou here: #14952 (comment) it looks like we crossed a threshold on the Go benchmarks and have added enough benchmarks for the Compute module that they are collectively taking more than 10m to run (which is the default timeout). So this updates the timeout used for running the benchmarks to 20 minutes. CC @ austin3dickey Authored-by: Matt Topol <[email protected]> Signed-off-by: Matt Topol <[email protected]>
|
Benchmark runs are scheduled for baseline = 6724fc1 and contender = 885e050. 885e050 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
4 participants
This PR changes
go_bench_adapt.pyto be more accurate about reporting GitHub information to Conbench from a local computer.In most cases, this script will be run on the master branch during this workflow. This PR shouldn't change that use case.
However, rarely, someone might run benchmarks locally on a branch on their computer. If that's the case, we want the GitHub information to be scraped from the local repo, instead of assuming it's on the master branch. This is accomplished by passing
Nonetogithub.